Sort:  

as long as you collect fees you will profit.

Usually yes. But if the price of X token starts to drop significantly while Y doesn't, the pool will rebalance. This could eat up the profits.