Thank you for your contribution. This is a nice idea.
- I notice that the code is not on an independent repro, instead there are some other irrelevant project(s), this makes it harder to see the changes log in the future.
- The code demonstrates well the idea, but it makes it hardly practical for general use. Expecially that not every people knows how to put the image paths into the temporal database.
- Also, directories and filenames are hard-coded in the code, you might want to improve the utility by accepting command line options.
- You might want to extract the functionalities as a few funtions/modules, so that you can add unit tests.
- Almost no comments, you might want to comment more - and in English :)
- And please also add more documentation in the README.md
- You might want to use Pull Request to group your commits.
Lookingforward to your next contribution.
According to Utopian policies and guidelines, here are two important ones that you will not want to miss:
To be considered for potential reward, Bug Fixes and New Features should be submitted via Pull Requests. The Pull Request should have been merged within the past 14 days.
Updates on Own Projects may be committed directly, without a Pull Request. To be considered for potential reward, commits should not be older than 14 days.
Happy New Year!
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @justyy! Keep up the good work!