Thanks, and exactly.
I considered adding a joke in there about data collection, a blockchain, and steemdb - but decided against it :)
You are viewing a single comment's thread from:
Thanks, and exactly.
I considered adding a joke in there about data collection, a blockchain, and steemdb - but decided against it :)
Hahhaha, everyone would not have understood that joke anyway. Would love to know all the bugs you encountered while doing the testing.
The first bug was fun... with dynamic numbers (which SP -> VEST math is), I ran into an issue where the request strategy ended up short by
0.0000000005 VESTS, and then in an attempt to allocate more vests, was actually ended up decreasing the size of the request by that amount. The loop was counting down from1028804.22191in0.0000000005increments hah, which would have finished someday and resulted in a failed request, but who knows how long that would have taken!The bandaid fix for that one was to just apply a small + (0.000001) to each vest addition in it's strategy. I'm going to have to dig in deeper to figure out where that value isn't being rounded properly to the 6th decimal.
In the mean time, bonus 0.000001 VESTS on every request LOL
Wow interesting bug though. The whole concept of vests always haunts me. Have to play with a lot of numbers and write an appropriate algo to deal with it. Great fix too. Bonus for all