RE: 64 bits Window binary compiled with VS 2013

[abit]

I'm replying here due to reached maximum nested level. Sorry for the late reply.

after it fully syncs, it crashed, not sure why.

Crash every time after fully synced? Logs and/or core dump etc would be useful.

when I was compiling cli_wallet, I got error C2593: 'operator <' is ambiguous
which is caused by found using ADL on ip.hpp(60).

It seems that in the cli_wallet code somewhere there is a comparison between two address objects, but class address lack of a operator <. Try

• add a line friend bool operator<(const address& a, const address& b); to class address, and
• add an implementation to ip.cpp?

  bool operator<( const address& a, const address& b ) {
    return uint32_t(a) < uint32_t(b);
  }

Comments

[alphabeta]

Update2:
Thank you @abit. All the below code change compiled without error.

FC_CAPTURE_AND_LOG( (_user_agent_string) )

• add a line friend bool operator<(const address& a, const address& b); >to class address
• add an implementation to ip.cpp?
  bool operator<( const address& a, const address& b ) { return uint32_t(a) < uint32_t(b); }

Except the latest commit. It has 7 error:
4 reference to raw.hpp line 294:
c2668: fc::raw::unpack : ambiguous call to overload function
and 3 reference to variant.hpp line53:
c2668 fc::from_variant : abmiguous call to overload funciotn

I don't think it is related to the code change.