Thanks for the contribution, @svijay1692! I'm glad to see the task request was successful! It also seems like a lot of work went into this (not just from you), and overall the quality seems high - great work! There are a couple of things I would like to point out though:
- I see you've left quite a few
console.logs throughout the code. I assume you used this for debugging, but I think it's better to remove it once the function has been completed, for example. - The spelling and / or grammar could be improved. I would recommend asking others to have a quick read over - it's easy to miss these mistakes, so more eyes always help!
- Add some comments / docstrings to the added functions. It will help future contributors (and yourself when coming back to old code).
I was also wondering if, since there are multiple authors working on the same branch (master) / pull request, it wouldn't be easier for you guys to separate this? You could create a branch for each feature and merge that into master (or create a develop branch) instead, but of course it's up to you.
Also, it takes a really long time for https://swapsteem.herokuapp.com/home to load (it took a long time to loa to 95% and then just got stuck). I don't know if this is because of Heroku, or because of something on Swapsteem's side - try to make sure this is working in the future.
Other than that everything looks great. Keep up the great work and good luck with future bug reports (I saw Swapsteem was added to the bug hunting whitelist)!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thanks @amosbastian for the review!
The demo is available at www.swapsteem.online, please referit for checking out the application.
We are a small team as of now, all of us having access to the repo. We will surely set up a git work flow for an ideal dev env.
Great! You should update the website linked in the repository from https://swapsteem.herokuapp.com to http://www.swapsteem.online/home in that case. Good luck with further development!
Thank you for your review, @amosbastian! Keep up the good work!