Thank you for the contribution. You have bot empire on Discord. :)
A couple of feedbacks:
Add roles with the permission to use the bot to line 18.
This is not a good practice for reusability. It would be good if you get this role group from a config file or a sys argument to the bot, or even from a environment variable. (Like how you do with RAFFLE_TOKEN.
Also, I see very long lines and non-standard indentation. I would strongly suggest following oeo8. It's pretty much an industry standard about how you style the python codes. (indentation 4 spaces instead of tabs, 80 char limit, etc.)
On last thing about the commit messages, we love descriptive commit messages at Utopian. Commit messages like "Update utils.py" doesn't mean much to the potential code/repository while "Add missing library import (random)" sounds like better. Here is a great guide about writing good commit messages.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Chat with us on Discord.
[utopian-moderator]Need help? Write a ticket on https://support.utopian.io/.
Thank you a lot! The editing at line 18 is indeed far from a perfect practice and I agree I should look into config files/ENV variables instead. I guess this is a better time for that than ever!
Thank you for letting me know about oeo8 as well. I'll spend some time today getting used to that as it'll surely improve the clarity and quality of my code.
Finally, the commit messages got a little messy when I tried to update the typos and simple mistakes, which shouldn't have happened. I tried to leave descriptive comments under them where applicable. That being said, thank you for the guidelines, I'll definitely check them out!
Hey @emrebeyler Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!