Hey! I'm pleased to see this project grow.
Let's go for the review:
You should separate the fixes and features, not put them in the same PR.
https://github.com/knacksteem/knacksteem-api/pull/14/files#diff-2dbc47226b708066000a2b1df9653f12R69 => I find this weird, the status is sent in the response header and then as JSON. Any reason for duplicating this information ?
You have in your comments
@param {Object} req: url params=> This is not accurate. The request contains much more information than just the url params.+1 for using express validate.
findOneAndUpdatewith permlink & author as search params.https://github.com/knacksteem/knacksteem-api/pull/15/files#diff-2dbc47226b708066000a2b1df9653f12R61 => You could do one query by using
Overall this is great work! Congratulations :)
See you for another contribution
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Chat with us on Discord.
[utopian-moderator]Need help? Write a ticket on https://support.utopian.io/.
Hey @gregory.latinier Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!