- Very beautiful formatting both on STEEM and github all at once.
- Great job on the test and explaining why it's important.
- Ironically, I would suggest that you run your tests on more platforms like linux to make sure it does run and that no globally installed program works for you and not others.
- There are some funny business with case sensitiveness of file names on Macs, beware!
- Now with the errors:
Error: Cannot find module './localStorageInjector.js'
fixed with :git mv seedSrc/storage/LocalStorageInjector.js seedSrc/storage/localStorageInjector.jsError: Cannot find module 'elliptic'
that's because you first need tonpm iboth foldersclientSrcandseedSrc.sh: 1: Electron: not foundwas fixed by including the path of the locally installed electron from npm and using this one to start.- You should
.gitignorethe.DS_Storefiles from your repo.
- I've created a pull request with the fixes: https://github.com/Cajarty/Seed/pull/9/
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @helo!
So far this week you've reviewed 2 contributions. Keep up the good work!
Wow, thank you very much for not only catching the errors and testing it on Linux, but also fixing the errors. Your changes were reviewed and approved.
I have Windows 10 and Fedora Linux on my Mac, however I've gotten lazy and am not in the habit of testing this project on the other platforms yet (mainly because no one else has claimed to have ran it other than my partner, who also uses Mac). I will make begin testing on all platforms from now on!
Thank you for your kind review