RE: QUIQQER Order Module - Multi Currency Feature

[justyy]

Thank you for your contribution.

1. You probably can chain your calls such as $TemporaryInvoice->getArticles()->setUser($this->getCustomer())->setCurrency($this->getCurrency() as currently the getArticles() has been invoked twice.
2. Two places of comment-out code - better to remove them to keep your codebase clean.
3. When users switch from one currency to another, it's better to conert the value automatically using third party currency converter API.
4. No unit tests found to cover the functionalities.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

---

Need help? Chat with us on Discord.

[utopian-moderator]

Comments

[utopian-io]

Thank you for your review, @justyy! Keep up the good work!