You are viewing a single comment's thread from:

RE: Minecolonies & Fancy Border Rendering

in #utopian-io6 years ago

Thank you for your contribution.

  1. You might be able to use javafx.util.Pair instead of creating Tuple
  2. You might want to extract this if (!c.getValue().equals(colonies.get(new Tuple<>(x - 1, z))) && colonies.containsKey(new Tuple<>(x - 1, z))) into a helper function since it contains duplication i.e. same tuple is created twice. Also, if four directions cannot be set at the same time, you might want to add else if instead.
  3. many magik numbers are hard to understand - better to define them as contants.
  4. code duplication could be extracted: bufferbuilder.pos(chunkCoordX + incX, levels, chunkCoordZ + incZ).color(1.0F, 1.0F, 1.0F, 0.0F).endVertex();

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!