You are viewing a single comment's thread from:

RE: SteemChain - Charts & Analytics V1.3.0

in #utopian-io6 years ago

Thank you for your contribution.

  1. I can see you have split the operations.py as recommended in your last utopian post, this looks good. It is recommended that you start to add unit tests to cover these changes.
  2. import * is in general not a good idea. I can understand it is handy, but as your project grows, so is the module dependency, and sometimes same function names will become probromatic especially if there is no namespace.
  3. In Javascript, use === instead of ==.
  4. You might want to replace the big chunks of if .. else if.. using the following styles:
def switch_demo(argument):
    switcher = {
        1: "January",
        2: "February",
        3: "March",
        4: "April",
        5: "May",
        6: "June",
        7: "July",
        8: "August",
        9: "September",
        10: "October",
        11: "November",
        12: "December"
    }
    print switcher.get(argument, "Invalid month")

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thanks for your feedback. I will have to do some research on unit tests, as this is new to new, and hope to have this implemented next week. Awesome to see the switcher, makes a lot of sense.

I will implement your other feedback in the next update.

Thank you for your review, @justyy! Keep up the good work!